Properly generate default value from yml & xml mapping#1327
Closed
j0k3r wants to merge 1 commit into
Closed
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3608 We use Jira to track the state of pull requests and the versions they got |
Member
There was a problem hiding this comment.
Could you add assertions for these changes? Or was the original assertion wrong?
Contributor
Author
There was a problem hiding this comment.
According to the documentation, the original assertion was wrong
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yaml & Xml mapping which define default value for a field aren't properly generated in the entity class by the
EntityGenerator.This is how the documentation says to define a default value in xml:
and in yml:
Both generates this field mapping (aka
$fieldMapping):But the
EntityGeneratorcheck the default value in the wrong place, in$fieldMapping['default']instead of$fieldMapping['options']['default'].This is related to :