Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed wrong property name#1507

Merged
guilhermeblanco merged 3 commits into
doctrine:masterfrom
deguif:fix-wrong-property
Nov 7, 2015
Merged

Fixed wrong property name#1507
guilhermeblanco merged 3 commits into
doctrine:masterfrom
deguif:fix-wrong-property

Conversation

@deguif
Copy link
Copy Markdown
Contributor

@deguif deguif commented Sep 11, 2015

No description provided.

@doctrinebot
Copy link
Copy Markdown

doctrinebot commented Sep 11, 2015

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3899

We use Jira to track the state of pull requests and the versions they got
included in.

@deeky666
Copy link
Copy Markdown
Member

deeky666 commented Sep 11, 2015

@deguif even though it's a trivial patch, it requires a regression test IMO

@billschaller
Copy link
Copy Markdown
Member

billschaller commented Sep 11, 2015

Definitely - clearly there's no existing test coverage... LOL

@deeky666
Copy link
Copy Markdown
Member

deeky666 commented Sep 11, 2015

@zeroedin-bill yes unfortunately. Therefore we should require at least tests to be added for touched methods.

@deguif
Copy link
Copy Markdown
Contributor Author

deguif commented Sep 14, 2015

I just added a test to cover this and found another bug.

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Nov 7, 2015

Assigning to @guilhermeblanco to change the test into a a test that doesn't hit the DB.

@Ocramius Ocramius added the WIP label Nov 7, 2015
guilhermeblanco added a commit that referenced this pull request Nov 7, 2015
@guilhermeblanco
Merge pull request #1507 from deguif/fix-wrong-property
d88cf97 
Fixed wrong property name
@guilhermeblanco guilhermeblanco merged commit d88cf97 into doctrine:master Nov 7, 2015
Ocramius added a commit that referenced this pull request Nov 7, 2015
@Ocramius
Merge branch 'hotfix/#1507-fixed-wrong-property-name-in-resultset-map…
39098ce 
…ping-builder' into 2.5

Backport merge #1507 into 2.5.x
Close #1507
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Nov 7, 2015

Backported to 2.5.x in 39098ce

@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@guilhermeblanco guilhermeblanco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deguif @doctrinebot @deeky666 @billschaller @Ocramius @guilhermeblanco