Conversation
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
There was a problem hiding this comment.
Identifiers are always arrays as of class metadata. We shouldn't introduce more inconsistencies on that one (already a mess in the various ODMs, where that interface is currently ignored).
There was a problem hiding this comment.
$id is a scalar when people call $entityManager->find("Entity", 1); Thats why the method is about normalizing.
There was a problem hiding this comment.
@beberlei yeah, but then we're adding this call everywhere (instead of just where the API states @param mixed $id). Nvm, guess it's an acceptable overhead.
|
This is almost 2 years old. Still relevant @beberlei ? If so, it would be great to merge the change. As the time goes by, potential merge conflict will grow. |
|
@guilhermeblanco can you allocate some of @FabioBatSilva's time to check this and #1113 PR? |
|
This has been partially handled in the |
|
@Ocramius Thanks! |
This work prepares for the merge of GH-232, allowing more complex and robust identifier hash generation.