Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clear entityInsertions for specific entityName#5850

Closed
ricohumme wants to merge 4 commits into
doctrine:masterfrom
ricohumme:master
Closed

Clear entityInsertions for specific entityName#5850
ricohumme wants to merge 4 commits into
doctrine:masterfrom
ricohumme:master

Conversation

@ricohumme
Copy link
Copy Markdown
Contributor

@ricohumme ricohumme commented Jun 3, 2016

See #5849

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jun 3, 2016

Requires test cases

@ricohumme
Copy link
Copy Markdown
Contributor Author

ricohumme commented Jun 3, 2016

Test case provided

Ocramius
Ocramius reviewed Jun 3, 2016
View reviewed changes
Comment thread lib/Doctrine/ORM/UnitOfWork.php Outdated
}

foreach ($this->entityInsertions as $hash => $entity) {
if (get_class($entity) != $entityName) {
Copy link
Copy Markdown
Member

@Ocramius Ocramius Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strict comparison needed here

Copy link
Copy Markdown
Member

@Ocramius Ocramius Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== or !==. Never rely on == and != unless strictly required to do so

Copy link
Copy Markdown
Contributor Author

@ricohumme ricohumme Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

Copy link
Copy Markdown
Member

@Ocramius Ocramius Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricohumme no need to comment on those: they disappear from the diff as soon as you push :-)

@Ocramius Ocramius added this to the 2.5.5 milestone Jun 3, 2016
@Ocramius Ocramius self-assigned this Jun 3, 2016
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jun 3, 2016

Test case provided

Thanks! \o/

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jun 5, 2016

Merged, thanks!

2.5 - 0af9ee0
master - 3bc61d5

Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 adding group annotations to the newly introduced test case
313e4a3
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 correcting test scenario: identity map could not be built…
34d8e00 
… with auto-generated identities+persist
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 renamed clearIdentityMap to `clearIdentityMapForEntityN…
14e0800 
…ame`, for clarity
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 refactored clearIdentityMapForEntityName to remove usel…
20d86c5 
…ess looping
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 renamed clearEntityInsertions to `clearEntityInsertions…
b9b952c 
…ForEntityName`, for clarity
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 minor performance optimization - avoiding get_class() c…
68c5d76 
…alls on all entity insertions
@Ocramius Ocramius closed this in 3bc61d5 Jun 5, 2016
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 adding group annotations to the newly introduced test case
7fbcbfa
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 correcting test scenario: identity map could not be buil…
7378035 
…t with auto-generated identities+persist
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 renamed clearIdentityMap to `clearIdentityMapForEntityN…
ec4dd4a 
…ame`, for clarity
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 refactored clearIdentityMapForEntityName to remove usel…
8002150 
…ess looping
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
#5849 #5850 renamed clearEntityInsertions to `clearEntityInsertions…
fecadf0 
…ForEntityName`, for clarity
Ocramius added a commit that referenced this pull request Jun 5, 2016
@Ocramius
Merge branch 'fix/#5850-clearing-specific-entity-name-should-clear-al…
0af9ee0 
…so-its-entity-insertions-2.5' into 2.5

Close #5850
Close #5849
@Ocramius Ocramius mentioned this pull request Jun 5, 2016
Closed
@ricohumme
Copy link
Copy Markdown
Contributor Author

ricohumme commented Jun 17, 2016

Hi,

When will 2.5.5 be released? I'm waiting for this one for one of my projects,

Thnx in advance

alexgurrola pushed a commit to Sitetheory-Archive/doctrine2 that referenced this pull request Apr 13, 2017
@Ocramius @alexgurrola
doctrine#5849 doctrine#5850 adding group annotations to the newly int…
b0fa47e 
…roduced test case
alexgurrola pushed a commit to Sitetheory-Archive/doctrine2 that referenced this pull request Apr 13, 2017
@Ocramius @alexgurrola
doctrine#5849 doctrine#5850 correcting test scenario: identity map c…
37f2441 
…ould not be built with auto-generated identities+persist
alexgurrola pushed a commit to Sitetheory-Archive/doctrine2 that referenced this pull request Apr 13, 2017
@Ocramius @alexgurrola
doctrine#5849 doctrine#5850 renamed clearIdentityMap to `clearIdent…
874a2b2 
…ityMapForEntityName`, for clarity
alexgurrola pushed a commit to Sitetheory-Archive/doctrine2 that referenced this pull request Apr 13, 2017
@Ocramius @alexgurrola
doctrine#5849 doctrine#5850 refactored `clearIdentityMapForEntityName…
ab30fb8 
…` to remove useless looping
alexgurrola pushed a commit to Sitetheory-Archive/doctrine2 that referenced this pull request Apr 13, 2017
@Ocramius @alexgurrola
doctrine#5849 doctrine#5850 renamed clearEntityInsertions to `clear…
ffa8aeb 
…EntityInsertionsForEntityName`, for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

Bug

Projects

None yet

Milestone

2.5.5

Development

Successfully merging this pull request may close these issues.

2 participants

@ricohumme @Ocramius