Fix hydration after fetch join on entity with composite primary key#5975
Fix hydration after fetch join on entity with composite primary key#5975kamazee wants to merge 3 commits into
Conversation
|
Yeah, this time Travis approves it. Would be cool if it makes it to 2.5.5 (I'll be happy to create another pull request for 2.5 as soon as this one is officially good enough). |
| parent::setup(); | ||
|
|
||
| $this->_schemaTool->createSchema(array( | ||
| $this->_em->getClassMetadata(__NAMESPACE__ . '\GH5762Driver'), |
There was a problem hiding this comment.
You could use ::class constant for all of these classes now, since the minor PHP version currently allowed is 5.6.
There was a problem hiding this comment.
Good point. Doctrine was stuck with 5.4 in my mind but looks like it's time to finally embrace the good things, isn't it?
|
Also, recalling a feedback from @Ocramius on one of the old PRs of mine, I removed accessors and made all the things simply public to increase signal/noise ratio. |
| $rowData = $this->gatherRowData($row, $id, $nonemptyComponents); | ||
|
|
||
| // reset result pointers for each data row | ||
| $this->resultPointers = array(); |
|
@Ocramius does 2.5 allow |
|
@kamazee ah yes, I'll probably have to revert some changes then :-\ |
This is a takeover of @jakestay's #5776 (fixes #5762).
Looks like the PR that has been taken over failed to pass the tests because of an intermittent CI issue, as it happens sometimes and got abandoned for that reason. It perfectly covers the issue I've stumbled upon recently so I'd like to bring it back and hope that this time Travis will behave :-)
Cherry picked on top of the current master.