Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix syntax error when join unrelated entity with discriminator entity#6812

Merged
lcobucci merged 1 commit into
doctrine:masterfrom
Deltachaos:bugfix/inheritance-joins-master
Dec 17, 2017
Merged

Fix syntax error when join unrelated entity with discriminator entity#6812
lcobucci merged 1 commit into
doctrine:masterfrom
Deltachaos:bugfix/inheritance-joins-master

Conversation

@Deltachaos
Copy link
Copy Markdown
Contributor

@Deltachaos Deltachaos commented Nov 6, 2017 •
edited
Loading

When joining a unrelated entity with a discriminator the join contains the table name and alias in brackets which is a syntax error (at least in SQL Server).

Exmaple:

SELECT
  c
FROM
  Doctrine\Tests\Models\Company\CompanyContract c
JOIN
  c.salesPerson s
LEFT JOIN
  Doctrine\Tests\Models\Company\CompanyEvent e WITH s.id = e.id

Results in:

SELECT
  c0_.id AS id_0,
  c0_.completed AS completed_1,
  c0_.fixPrice AS fixPrice_2,
  c0_.hoursWorked AS hoursWorked_3,
  c0_.pricePerHour AS pricePerHour_4,
  c0_.maxPrice AS maxPrice_5,
  c0_.discr AS discr_6
FROM
  company_contracts c0_
INNER JOIN
  company_employees c1_ ON c0_.salesPerson_id = c1_.id
LEFT JOIN
  company_persons c2_ ON c1_.id = c2_.id
LEFT JOIN
  (company_events c3_) ON (c2_.id = c3_.id)
WHERE
  c0_.discr IN ('fix', 'flexible', 'flexultra')

After the fix it results in:

SELECT
  c0_.id AS id_0,
  c0_.completed AS completed_1,
  c0_.fixPrice AS fixPrice_2,
  c0_.hoursWorked AS hoursWorked_3,
  c0_.pricePerHour AS pricePerHour_4,
  c0_.maxPrice AS maxPrice_5,
  c0_.discr AS discr_6
FROM
  company_contracts c0_
INNER JOIN
  company_employees c1_ ON c0_.salesPerson_id = c1_.id
LEFT JOIN
  company_persons c2_ ON c1_.id = c2_.id
LEFT JOIN
  company_events c3_ ON (c2_.id = c3_.id)
WHERE
  c0_.discr IN ('fix', 'flexible', 'flexultra')

I have created #6811 PR for backporting this to the 2.5 branch as well.

@Deltachaos Deltachaos mentioned this pull request Nov 6, 2017
Closed
This was referenced Nov 15, 2017
Closed
Merged
@Majkl578 Majkl578 added the Bug label Dec 8, 2017
@lcobucci lcobucci force-pushed the bugfix/inheritance-joins-master branch from c2274d2 to 32c125d Compare December 17, 2017 00:25
lcobucci
lcobucci approved these changes Dec 17, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied some small changes to reduce the complexity and it LGTM 👍

@lcobucci lcobucci self-assigned this Dec 17, 2017
@lcobucci lcobucci modified the milestones: 2.6.0, 2.5.14 Dec 17, 2017
lcobucci added a commit to lcobucci/doctrine2 that referenced this pull request Dec 17, 2017
@lcobucci
Merge branch 'backport/bugfix/inheritance-joins' into 2.5
2260381 
Backporting doctrine#6812
@lcobucci lcobucci merged commit d3ff823 into doctrine:master Dec 17, 2017
@lcobucci
Copy link
Copy Markdown
Member

lcobucci commented Dec 17, 2017

@Deltachaos 🚢 and backported! Thanks!

BourotBenjamin added a commit to BourotBenjamin/doctrine2 that referenced this pull request Dec 21, 2017
@BourotBenjamin
Merge tag 'v2.5.14' into NonMappedEntityFields
6b1f21a 
v2.5.14

This version backports bugfixes related to the generation of queries with joins
and configuration of the result set cache profile of a query.

Total issues resolved: **2**

Bug

- [6748: Fix missing null check on `AbstractQuery#setResultCacheProfile()`](doctrine#6748) thanks to @KonstantinKuklin
- [6812: Fix syntax error when join unrelated entity with discriminator entity](doctrine#6812) thanks to @Deltachaos
21skills added a commit to 21skills/orm that referenced this pull request Jan 27, 2021
@21skills
Extra brackets if no cti joins fix
f27d030 
Continuation of a problem from
doctrine#6812
The same problem appears if you add WITH condition to the joined entity with discriminator
@21skills 21skills mentioned this pull request Jan 27, 2021
Closed
greg0ire pushed a commit to piowin/orm that referenced this pull request Jul 23, 2021
@21skills @greg0ire
Extra brackets if no cti joins fix
20be56e 
Continuation of a problem from
doctrine#6812
The same problem appears if you add WITH condition to the joined entity with discriminator
greg0ire pushed a commit to piowin/orm that referenced this pull request Jul 23, 2021
@21skills @greg0ire
Extra brackets if no cti joins fix
86703cb 
Continuation of a problem from
doctrine#6812
The same problem appears if you add WITH condition to the joined entity with discriminator
@greg0ire greg0ire mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lcobucci lcobucci lcobucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lcobucci lcobucci

Labels

Bug

Projects

None yet

Milestone

2.5.14

Development

Successfully merging this pull request may close these issues.

3 participants

@Deltachaos @lcobucci @Majkl578