Fix date issues once and for all#7055
Merged
lcobucci merged 2 commits intoFeb 9, 2018
Merged
Conversation
Member
Author
|
@Majkl578 I've added to |
Merged
29 tasks
Majkl578
reviewed
Feb 9, 2018
|
|
||
| self::assertEquals($expectedValue, $diff, '', $delta); | ||
| self::assertEquals( | ||
| (new DateTimeImmutable($result['now']))->modify(sprintf('+%d %s', $amount, $unit)), |
Contributor
There was a problem hiding this comment.
Afaik CS currently prefers \DateTimeImmutable instead of use for global types, but allows both. https://github.com/doctrine/coding-standard/blob/3.0.0/lib/Doctrine/ruleset.xml#L158
Member
Author
There was a problem hiding this comment.
Stupid IDE config HAHAHA, will change, thanks!
Now using PHP to calculate the expected date manipulation, keeping a day as delta since PHP resets the hour when performing operations with days/weeks/months/years. February is a wonderful month, isn't it?
For the DATE_SUB() and DATE_ADD() functions.
608a9b4 to
9753421
Compare
Majkl578
approved these changes
Feb 9, 2018
Contributor
Majkl578
left a comment
There was a problem hiding this comment.
Travis failure unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe now things will work properly...