Fix wrong type in phpdoc of Doctrine\ORM\Id\AbstractIdGenerator#generate()#7190
Merged
Conversation
\Doctrine\ORM\Mapping\Entity is the annotation class which is not correct. The entity object itself is meant here as tests also assume see https://github.com/doctrine/doctrine2/blob/2.6/tests/Doctrine/Tests/ORM/Id/AssignedGeneratorTest.php#L28 Found this when running phpstan on our code that used a custom generator.
Member
|
@Tobion is this still occurring in |
Contributor
Author
|
I don't find the ID generators in master. Did they get extracted somewhere? |
Contributor
Author
|
It's fixed in master https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Sequencing/Generator.php#L16 The namespace got changed. This breaking change seems to be missing in the uprade file. |
Ocramius
approved these changes
Apr 13, 2018
Doctrine\ORM\Id\AbstractIdGenerator#generate()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\Doctrine\ORM\Mapping\Entity is the annotation class which is not correct. The entity object itself is meant here as tests also assume see https://github.com/doctrine/doctrine2/blob/2.6/tests/Doctrine/Tests/ORM/Id/AssignedGeneratorTest.php#L28
Found this when running phpstan on our code that used a custom generator.