Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove not used variable $reflFieldValue in ObjectHydrator#7840

Merged
mikeSimonson merged 1 commit into
doctrine:masterfrom
peter-gribanov:reflFieldValue
Sep 30, 2019
Merged

Remove not used variable $reflFieldValue in ObjectHydrator#7840
mikeSimonson merged 1 commit into
doctrine:masterfrom
peter-gribanov:reflFieldValue

Conversation

@peter-gribanov
Copy link
Copy Markdown
Contributor

fix #7834

Copy link
Copy Markdown
Contributor

@mikeSimonson mikeSimonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeSimonson mikeSimonson merged commit d528f70 into doctrine:master Sep 30, 2019
@peter-gribanov peter-gribanov deleted the reflFieldValue branch September 30, 2019 08:40
@lcobucci lcobucci added this to the 3.0 milestone Oct 1, 2019
@lcobucci
Copy link
Copy Markdown
Member

lcobucci commented Oct 1, 2019

@peter-gribanov I'm a bit confused here... this has been reported to v2.6 but sent to master. Which branch should have been the destination?

@peter-gribanov
Copy link
Copy Markdown
Contributor Author

@lcobucci this problem is in versions 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1. In version 2.0 there is no this problem.

@lcobucci
Copy link
Copy Markdown
Member

lcobucci commented Oct 2, 2019

@peter-gribanov alright, thanks for your reply!
Branches < 2.6 aren't supported so these aren't relevant. I'll backport this one to 2.6, which will also be applied in 2.7 once it gets rebased.

Please check https://github.com/doctrine/orm#which-branch-should-i-choose on the next PRs 👍

@peter-gribanov peter-gribanov restored the reflFieldValue branch October 3, 2019 08:11
@peter-gribanov peter-gribanov deleted the reflFieldValue branch October 3, 2019 08:14
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused local variable 'reflFieldValue'

4 participants