Fix OrderByItem parser to proceed with SimpleArithmetic expression before function#8277
Conversation
|
Please improve your commit message according to the contributing guide. Also, please associate your email address with your Github account, or change the |
Here is how it could look like: |
37633cc to
1051473
Compare
There is parser bug for OrderByItem(), where a function is detected before a SimpleArithmeticExpression while it should be the reverse: simple arithmetic expressions can start with a function too, and thus they should be matched first if present. This fix enables the use of expressions in sorting and with window functions.
|
Thanks @greg0ire for your feedback, they should now all be resolved |
SenseException
left a comment
There was a problem hiding this comment.
I was playing around with DQL and these changes and couldn't find anything that broke with it. The order of cases could have had an impact on other use cases, but it didn't.
Hi,
Fix #7626
There is parser bug for
OrderByItem(), where a function is detected before a SimpleArithmeticExpression while it should be the reverse: simple arithmetic expressions can start with a function too, and thus they should be matched first if present.This fix enables the use of expression in sorting and with window functions.