rename parameters to match parents#8284
Merged
Merged
Conversation
greg0ire
approved these changes
Sep 25, 2020
ostrolucky
approved these changes
Sep 25, 2020
SenseException
approved these changes
Sep 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR propose changing parameter names when they don't match parents.
This is suggested by the lastest version of Psalm in preparation for PHP 8 named arguments.
Here is the rationale: https://psalm.dev/docs/running_psalm/issues/ParamNameMismatch/
This may not be something we care about or that we want to support. In that case, I will change Psalm's config to ignore those in the future.
I don't believe changing parameter names is a BC break for now so we may want to do this now rather than a few months down when PHP8 will be available.