Start moving travis phpunit runs to Github actions.#8317
Conversation
15e8077 to
cce33f3
Compare
greg0ire
left a comment
There was a problem hiding this comment.
I see we no longer use composer install… should composer.lock be removed from version control?
|
@greg0ire its a good question about composer install/update, this probably goes hand in hand with pin tooling versions to specific versions to avoid failures suddenly starting due to new versions of psalm, phpunit, phpstan, phpcs... |
|
@beberlei see https://github.com/orgs/doctrine/teams/doctrinecore/discussions/21 if you want to dive into that rabbit hole :) |
This comment has been minimized.
This comment has been minimized.
67e35df to
91d9d25
Compare
91d9d25 to
4601127
Compare
This removes all artifacts used for TravisCI testing and replaces them with the existing infrastructure for Github Actions from DBAL component. In addition some test changes were needed and triggered larger Coding Style cleanups in 3 test files.
7a69930 to
ecdbf81
Compare
|
Guess I will have to upgrade to PHPUnit 8 😅 UPD: upgrading to PHPUnit 8 seems impossible because of a conflict between the API of TestCase and VerifyDeprecation I will try using XDebug instead, let's hope it will not slow down the build too much 🤞 UPD: actually I can just rename the VerifyDeprecations API, it's not public. |
917544c to
ecdbf81
Compare
|
It's going to be too big, let's merge your PR as is, I'll do the PHPUnit 8 migration and coverage upload in a separate PR. |
| - "7.3" | ||
| - "7.4" | ||
| deps: | ||
| - "fixed" |
There was a problem hiding this comment.
Should we use "normal" here? You are using composer update, so the dependencies are not fixed.
|
Let's remove |
Move from Travis CI to Github for PHPUnit tests.