Fix invalid psalm annotation#8374
Merged
Merged
Conversation
snapshotpl
approved these changes
Dec 5, 2020
greg0ire
approved these changes
Dec 5, 2020
Member
|
Thanks @micheh! |
This was referenced Dec 18, 2020
Closed
|
@greg0ire Hi Greg, is there an idea when this will make it into a release? |
Member
|
I think it will be released during this quarter. 🔮 |
|
While awaiting the release and for anyone else running into this issue, I ignored the error for now using: <!-- @TODO: Remove this when https://github.com/doctrine/orm/issues/8395 is resolved -->
<issueHandlers>
<InvalidDocblock>
<errorLevel type="info">
<file name="vendor/doctrine/orm/lib/Doctrine/ORM/EntityRepository.php" />
</errorLevel>
</InvalidDocblock>
</issueHandlers> |
@7ochem this is amazing ... just what I needed. I disabled psalm checks in our CI, now I can add them back, thank you so much |
Member
|
Prediction fulfilled: https://github.com/doctrine/orm/releases/tag/2.8.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The psalm annotation is currently invalid and psalm outputs an error:
ERROR: InvalidDocblock - vendor/doctrine/orm/lib/Doctrine/ORM/EntityRepository.php:74:5 - Badly-formatted @param in docblock for Doctrine\ORM\EntityRepository::__construct (see https://psalm.dev/008)