Fixing bug where indented table header was seen as a dl#165
Merged
Conversation
greg0ire
approved these changes
Oct 17, 2021
Member
|
Thanks @weaverryan ! |
wouterj
reviewed
Oct 18, 2021
| $this->buffer->push($line); | ||
|
|
||
| return true; | ||
| } else { |
Collaborator
There was a problem hiding this comment.
Wouldn't it be more logical if we slightly reorganize these nested if statements?
} elseif ($separatorLineConfig = $this->tableParser->parseTableSeparatorLine($line)) {
$this->setState(State::TABLE);
$tableNode = $this->nodeFactory->createTableNode(
// ... (from line 313)
} elseif ($this->lineChecker->isIndented($this->lines->getNextLine())) {
$this->setState(State::DEFINITION_LIST);
// ... (from line 291)
} elseif ($this->getCurrentDirective() !== null && ! $this->getCurrentDirective()->appliesToNonBlockContent()) {
// ... (from line 298)
} else {
$this->setState(State::NORMAL);
return false;
}
Collaborator
Author
There was a problem hiding this comment.
Almost definitely :). Please propose if if you have a vision - I'm a big fan of incrementally tweaking this library simply in order to make the code more understandable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We found this small bug from the Symfony documentation. If a simple table's header started with a space:
Then the entire structure was seen as a definition list, instead of a table. The fix is pretty logical: we check FIRST if the top line (e.g.
===== ===== ====) is a valid "table separator". And only if it is NOT, we then check to see if the next line (e.g.COL A COL B COL C) is indented to trigger a definition list.Cheers!