Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update remark dependencies #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raninan opened this issue Jan 13, 2021 · 3 comments
Closed

Update remark dependencies #1349

raninan opened this issue Jan 13, 2021 · 3 comments
Assignees
@anthony-redFox

Comments

@raninan
Copy link

raninan commented Jan 13, 2021

The latest version of documentation still calls out to older versions of remark which have serious security vulnerabilities in them; for example: trim-0.0.1 called as a sub dependency from remark 9. meanwhile trim has moved on to 1.0.0

  • My current version: documentation-13.1.0
  • Used as a sub dependency of taiko
@tmcw
Copy link
Member

tmcw commented Jan 19, 2021

Happy to accept a PR. These kinds of security vulnerabilities are never actually exploitable or worth worrying about, but the automated checkers will nag us nonetheless.

@lalli-flores
Copy link

lalli-flores commented Feb 18, 2021 •
edited
Loading

@tmcw, I've opened a PR, #1357, with the dependencies update. Can you take a look?

Seems like after updating remark the parser's prototype has changed and initializeTokenizers is not there anymore, so the doc command breaks when assigning the tokenizeLink. I'd appreciate some help fixing this issue, given I am totally new to this codebase (and the remark project) 🙂

@lalli-flores lalli-flores mentioned this issue Mar 18, 2021
Closed
@anthony-redFox anthony-redFox self-assigned this Apr 7, 2021
@anthony-redFox
Copy link
Member

remark has new engine started 13 version. I updated on last 12.0 which still compatible with us.

anthony-redFox added a commit to anthony-redFox/documentation that referenced this issue Apr 18, 2021
@anthony-redFox
deps: update remark on last version fixed documentationjs#1349
2bbbce7 
1. New plaugins was created parse jsDoc link and remove position
2. spread: false - to remove new line after each listItem
anthony-redFox added a commit to anthony-redFox/documentation that referenced this issue Apr 18, 2021
@anthony-redFox
deps: update remark on last version fixed documentationjs#1349
10ea4ed 
1. New plugins was created parse jsDoc links and remove position
2. spread: false - to remove new line after each listItem
@tmcw tmcw closed this as completed in f4a46b1 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthony-redFox anthony-redFox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tmcw @anthony-redFox @lalli-flores @raninan