ci: the gate's step 8 says how to check the registry, not how to fix it - #33
Closed
docushell-dev wants to merge 1 commit into
Closed
docushell-dev wants to merge 1 commit into
docushell-dev wants to merge 1 commit into
Conversation
`ci/sdk-suites.sh` already tells a reader whose `npm install` failed that `npm config get registry` is the first thing to check, and that a registry it cannot reach fails the gate rather than silently producing a partial one. Both true, and it stops one step short of the remedy. Behind a corporate proxy the step fails TWICE OVER and neither message points anywhere useful: ENOTFOUND against an internal mirror with the VPN down, then CERT_HAS_EXPIRED against the same host with it up. Reading either, the natural conclusion is that the mirror is broken and there is nothing to be done — when in fact exporting the proxy for the run fixes it outright, and the gate then passes all eight checks including the fourteen Node tests that otherwise skip. That cost an afternoon to work out from the error text alone. The remedy is now IN the error text. The hosts named are one organisation's and are labelled as such; what transfers is the shape — export for the run, change nothing persistent. The message says explicitly that `npm config set` is NOT the advice, because a gate that edits your tooling in order to pass is a gate nobody can trust afterwards. Error-message text only. Nothing executes on the passing path; `bash -n` clean. Co-Authored-By: Claude Opus 5 <[email protected]> Signed-off-by: docushell-dev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci/sdk-suites.shalready tells a reader whosenpm installfailed thatnpm config get registryis the first thing to check, and that an unreachable registry fails the gate rather than silently producing a partial one. Both true — and it stops one step short of the remedy.Behind a corporate proxy the step fails twice over, and neither message points anywhere useful:
ENOTFOUNDagainst an internal mirror with the VPN down, thenCERT_HAS_EXPIREDagainst the same host with it up. Reading either, the natural conclusion is that the mirror is broken and there's nothing to be done.In fact exporting the proxy for the run fixes it outright — and the gate then passes all eight checks, including the fourteen Node tests that otherwise skip while the run still exits 0. That's the state this repository shipped in until 0.42.1, which is why step 8 refuses to treat a missing dependency as a skip.
Working that out from the error text alone cost an afternoon. The remedy is now in the error text.
Two deliberate choices in the wording:
npm config setis not the advice. A gate that edits your tooling in order to pass is a gate nobody can trust afterwards.Error-message text only; nothing executes on the passing path.
bash -nclean.I'll add the
ci/gate.shresult before merge — an end2end verification run for 0.54.0 is using the machine and I didn't want the two competing, same as #31.🤖 Generated with Claude Code