Menu: check context visibility after assembling items #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #4400. By checking the context visibility after the assembly, the context is properly checked for plugin items.
I am not sure why moving the context visibility check to a later stage suddenly surfaced the issue of $INFO not being set in the general_html_test. I would have expected the same issue before the changes of 33792c0 In any case it makes not much sense to do the permission checks there anyway. Doing it in the constructor makes more sense since this is not a context sensitive check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4400. By checking the context visibility after the assembly, the context is properly checked for plugin items.