forked from angular/angular.js
-
Notifications
You must be signed in to change notification settings - Fork 0
sync #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
sync #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add linked list to top of document - add anchor elements to secondary headings closes #6287
- add missing 'C' restriction for class names
Mention common cause of error is binding to a new array on every $digest loop. Closes #6465
- add a link to a tutorial on intergrating angular and django
Duplicate 'that' words present in the document, just remove one of them. Closes #6469
I removed the complexity metric as suggested by this blog post on triaging: http://www.lostgarden.com/2008/05/improving-bug-triage-with-user-pain.html (see The temptation to assign ‘cost’) Big thanks to @ashleygwilliams and @davidjnelson for their help and feedback!
Dates are not returned, so remove Date from list of return values. Closes #3070
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes #5378
Make it clear that the result of the $parsers pipeline is what goes to the model value. Closes #5708
Closes #5759 The default trusted origin appears to be the same protocol+domain+port, non just protocol+domain. I patched the doc accordingly.
This reverts commit e14d1a7.
… inheritance If a JS animation is run before a CSS animation then the JS animation may end up writing style data to the element. If any transition or animation style data is written then it may end up being accidentally inherited into the CSS animation hanlder that ngAnimate uses. This may result in an unexpected outcome due to the tweaks and hacks that the CSS handler places on the element. If the CSS animation is run before the JS animation then, if there are no transitions on the style attribute nor within the global CSS on the page then nothing will happen and the JS animation can work as expected. Closes #6675
$animate attempts places a `transition: none 0s` block on the element when the first CSS class is applied if a transition animation is underway. This works fine for structural animations (enter, leave and move), however, for class-based animations, this poses a big problem. As of this patch, instead of $animate placing the block, it is now the responsibility of the user to place `transition: 0s none` into their class-based transition setup CSS class. This way the animation will avoid all snapping and any will allow $animate to play nicely with class-based transitions that are defined outside of ngAnimate. Closes #6674 Closes #6739 BREAKING CHANGE: Any class-based animation code that makes use of transitions and uses the setup CSS classes (such as class-add and class-remove) must now provide a empty transition value to ensure that its styling is applied right away. In other words if your animation code is expecting any styling to be applied that is defined in the setup class then it will not be applied "instantly" default unless a `transition:0s none` value is present in the styling for that CSS class. This situation is only the case if a transition is already present on the base CSS class once the animation kicks off.
Using node_module/.bin/gulp will enable to gulp command to run both on Windows and Linux. In its current form, the default action of executing a Javascript file on Windows does not use node. Requires quotes around the command to correctly resolve path on Windows Closes #6346
This is no more needed as phonecat and seed are using bower now to get the angular version.
The CDN version of angular is now calculated on every build, by looking at the tags in angular/angular.js, sorting them by semver and checking against ajax.googleapis.com which one is available.
The homepage (angularjs.org) and the docs now calculate the current cdn version on every build, so there is no need for an after-cdn script.
The `git fetch --all` resulted in an error if in the local `.gitconfig` a remote was configured that does not exist in the bower/code.anguarjs.org repositories (e.g. "remote "upstream-prs"").
Typo 'hrml' Oops! Closes #6874
Makes xhr status text accessible is $http success/error callback. See www.w3.org/TR/XMLHttpRequest/#dom-xmlhttprequest-statustext Closes #2335 Closes #2665 Closes #6713
The doc mentions filters can be used in services and controllers but directives aren't mentioned. This could lead to confusion for beginners.
Closes #6882
Due to a known V8 memory leak[1] we need to perform extra cleanup to make it easier for GC to collect this scope object. The theory is that the V8 leaks are due to inline caches which are caches built on the fly to speed up property access for javascript objects. By cleaning the scope object and removing all properties, we clean up ICs as well and so no leaks occur. I was able to manually verify that this fixes the problem for the following example app: http://plnkr.co/edit/FrSw6SCEVODk02Ljo8se?p=preview Given the nature of the problem I'm not 100% sure that this will work around the V8 problem in scenarios common for Angular apps, but I guess it's better than nothing. [1] V8 bug: https://code.google.com/p/v8/issues/detail?id=2073 Closes #6794 Closes #6856
dolfly
added a commit
that referenced
this pull request
Mar 31, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync