-
Notifications
You must be signed in to change notification settings - Fork 50
Editorial subs (first third of Worm) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Correct various grammatical errors and improve punctuation throughout the text.
minor spacing issues
domenic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome finds; I really appreciate this!
I have a few notes I left inline; let me know your thoughts on them.
For some of your changes, e.g. around innumerable, coastline, fewer, I'm a bit torn between preserving "what the characters said/narrated" vs. what's less jarring for the reader. That is, we could say that Taylor just isn't very good at knowing how to use less vs. fewer, or Coil has a quirk of speech where he thinks "coastline" is a place to take someone. So if we err on the side of preserving author intent, then we should leave these as-is.
But, these cases were jarring enough for you as a reader for you to come here and make these suggestions. And the changes you suggest don't change the text in big ways. (Whereas, there are some "mistakes" in the last few arcs which are definitely intentional given the context.)
So on balance I think we should accept your changes. I just wanted to make sure you considered this aspect.
substitutions/worm.subs
Outdated
| + Obviously,” Kaiser said, “I ended | ||
|
|
||
| - she was stumbling back and away from Lung and throw her shield away | ||
| + she was stumbling back and away from Lung and throw her shield away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| + she was stumbling back and away from Lung and throw her shield away | |
| + she was stumbling back and away from Lung and throwing her shield away |
right?
substitutions/worm.subs
Outdated
| + “Right,” Weld replied, feeling lost. “They’re the ones | ||
|
|
||
| - Kid Win and Vista arrived from what the | ||
| + Kid Win and Vista arrived from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find this in the source. The best I have is Kid Win and Vista arrived from the ‘cubicles’ at the far end of the spacious room.
substitutions/worm.subs
Outdated
| + what a Merchants party is all about | ||
|
|
||
| - Maybe middle-aged, bleached blond hair | ||
| + Maybe middle-aged, bleached blonde hair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
worm-scraper/lib/convert-worker.js
Lines 1091 to 1099 in e7d4a62
| // The author seems to attempt to use "blonde" for females and "blond" for males, including in both adjective and noun | |
| // positions. However, the books are very inconsistent; I identified 20+ misuses before giving up. | |
| // | |
| // Modern style guides tend to prefer using "blond" for all adjectives, sometimes allowing "blonde" as a noun, but | |
| // also saying that using "blond" as the noun uniformly is fine and somewhat preferred. See "Spelling Note" in | |
| // https://www.dictionary.com/browse/blonde. | |
| // | |
| // Instead of trying to painstakingly adhere to the seeming authorial intent, we'll just standardize on "blond". | |
| xml = xml.replace(/(B|b)londe/vg, "$1lond"); |
We should not add this substitution.
substitutions/worm.subs
Outdated
|
|
||
|
|
||
| - middle-aged woman with bleached blond hair | ||
| + middle-aged woman with bleached blonde hair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, we should not add this substitution.
substitutions/worm.subs
Outdated
| - “Something about the way that one moved,” Newter pointed at Jaw with his tail, “Reminded me of some | ||
| + “Something about the way that one moved,” Newter pointed at Jaw with his tail, “reminded me of some | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no spaces on blank lines)
substitutions/worm.subs
Outdated
|
|
||
| - Innumerable others had died because we | ||
| + So many others had died because we | ||
| # The paragraph prceeds to ennumerate the deaths, so 'innumerable' doesn't quite fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # The paragraph prceeds to ennumerate the deaths, so 'innumerable' doesn't quite fit. | |
| # The paragraph proceeds to say exactly how many deaths, so 'innumerable' doesn't quite fit. |
|
Thanks for the thoughtful response. Yes, I did consider this aspect, and rejected a few more ideas for precisely the reason you mentioned. These just crossed my threshold. But I'm not wedded to them, and if you prefer to remove some, please feel free! The "fewer" example is definitely cuttable. |
|
Got it, glad to hear you were thinking along those lines too! As I said, I think all your choices make sense. Do you have thoughts on the other inline comments I left? Especially #74 (comment) . I can fix the rest and complete merging the PR myself, but I was unsure what to do with that one. |
|
Thanks for the comments. I overlooked them at first on the mobile app, but agree with them (and see you've since merged), except for one which took me longer to track down. That was: You said:
I find that in the source here:
I can't work out whether I'm looking at a different source to you. Hope this helps. Sorry for overlooking your 'blond' decision too! |
I appreciate your subs engine and have been highlighting errors as I read. I'm at the one-third milestone so contributing a few edits back upstream.
Thanks for the tool!