forked from matplotlib/matplotlib
-
Notifications
You must be signed in to change notification settings - Fork 2
Anim io #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Anim io #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -591,7 +591,8 @@ def _step(self, *args): | |||
self.event_source.add_callback(self._loop_delay) | |||
self.event_source.interval = self._repeat_delay | |||
self.frame_seq = self.new_frame_seq() | |||
return True | |||
# Try drawing again, but now at the beginning of the sequence | |||
return Animation._step(self, *args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to conditionally happen here, or in the loop delay handler, otherwise the next frame gets drawn, then the animation delays, which is not the intention.
I fixed in a different way. See if that solves the problem for you. |
dopplershift
pushed a commit
that referenced
this pull request
Jul 20, 2012
Fix get_sample_data under Python 2
dopplershift
pushed a commit
that referenced
this pull request
Oct 8, 2012
Add texinfo support to plot directive
dopplershift
pushed a commit
that referenced
this pull request
Oct 31, 2012
Create the symlink without using chdir.
dopplershift
pushed a commit
that referenced
this pull request
Jan 15, 2015
…qt_fix Instantiate Sip Mock before use
dopplershift
pushed a commit
that referenced
this pull request
Jun 23, 2015
Create colormap_normalizations.py
dopplershift
pushed a commit
that referenced
this pull request
Jan 26, 2016
One too many assertions Closes #1
dopplershift
pushed a commit
that referenced
this pull request
Oct 25, 2016
DOC minor fixes on the documentation of errorbar
dopplershift
pushed a commit
that referenced
this pull request
Jan 31, 2017
Determinism tests without temporary files
dopplershift
pushed a commit
that referenced
this pull request
Jan 31, 2017
FIX pep8 failed as some files are pep8 compliant
dopplershift
pushed a commit
that referenced
this pull request
Oct 20, 2017
This fixes some possible heap buffer overflows, such as the following triggered by our cmmi10.ttf: ``` ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0 READ of size 1 at 0x617000235709 thread T0 #0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178 #1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339 #2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325 #3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420 #4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:217 0x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708) allocated by thread T0 here: #0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38) #1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140 ```
dopplershift
pushed a commit
that referenced
this pull request
Mar 27, 2020
Add link to blog to front page matplotlib#16487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an animation loop hiccup that occurs for TimedAnimations that wants looping, but does not provide a cyclable iterator.