You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have tsschecker v244 installed at /usr/local/bin/tsschecker (via @stek29's homebrew tap) but receive "Please put tsschecker" as terminal output/error when attempting to run getshsh.sh. Running on macOS 10.13.6
I'd suggest labeling the error better, by appending "binary in project directory" to that error message or checking if tsschecker is installed in /usr/local/bin, use that version
Thing is, /usr/local/bin is included in my PATH for both fish + bash, but the original shell script references a local copy of tsschecker here, here, and here.. so at minimum a tsschecker symlink would need to be created in the project directory.
My pull is meant to simplify the process: if tsschecker can't be found, return a more detailed error message that doesn't require you to be fluent in shell script to remedy ¯_(ツ)_/¯
I'm saying that your PR is a bad idea -- PATH exists for a reason. Instead of trying to find tsschecker in some predefined list, it should just let shell do it, and one of the ways to get path to a binary in PATH is command -v tsschecker.
The reason will be displayed to describe this comment to others. Learn more.
just else would be enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stek29
left a comment
I have tsschecker v244 installed at /usr/local/bin/tsschecker (via @stek29's homebrew tap) but receive "Please put tsschecker" as terminal output/error when attempting to run getshsh.sh. Running on macOS 10.13.6
I'd suggest labeling the error better, by appending "binary in project directory" to that error message or checking if tsschecker is installed in /usr/local/bin, use that version