Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use funcloader for cairo library in cairo extensions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 15, 2022

Conversation

gluckez
Copy link
Collaborator

@gluckez gluckez commented Aug 5, 2022

This pr introduces a cairo library definition to centralize logic to load functions from cairo libraries for different platforms, and uses them in the cairo extensions.

@gluckez
Copy link
Collaborator Author

gluckez commented Aug 20, 2022

@lytico @hwthomas Can you have a look and provide some feedback on this please? I also noticed that the pipeline fails now, where it didn't before, and it builds fine locally.

@hwthomas
Copy link
Collaborator

@gluckez I haven't been able to look at your code changes yet, but the CI pipeline failure is very familiar - it fails with

DOWNLOADNUPKG : Ssl error : 1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED

and very often will run OK next time. However, you'd need to set up your own CI pipeline to be able to do that

@gluckez
Copy link
Collaborator Author

gluckez commented Aug 22, 2022

@hwthomas Thanks :) I'll have a look at that pipeline setup, maybe I can just replicate that.
EDIT: I duplicated the pipeline from this repo, and added another that uses dotnet 6 and ubuntu2204:
https://github.com/gluckez/dotdevelop/runs/7953517515?check_suite_focus=true
seems to run just fine.

@lytico
Copy link
Member

lytico commented Aug 22, 2022

CI related stuff should be an extra PR. it's not a good idea to mix different tasks in one PR.

@gluckez
Copy link
Collaborator Author

gluckez commented Aug 23, 2022

@lytico I added the CI related stuff on another branch on my own fork, it was just for testing anyway.
EDIT: never mind that, it seems like it was added on this pr for some reason :/
EDIT2: slightly confusing there. I originally added it on the main branch, which caused it to show up here, but removed it afterwards and added it on a different branch.

@gluckez
Copy link
Collaborator Author

gluckez commented Oct 10, 2022

@lytico and @hwthomas is it possible to review this pr? it's been open for quite a while now and doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants