Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fsharp api v3 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 11, 2023
Merged

Fsharp api v3 #93

merged 13 commits into from
Jan 11, 2023

Conversation

hwthomas
Copy link
Collaborator

No description provided.

 and update MSBuildEvaluationContext.cs accordingly

    IntrinsicFunctions are now loaded at runtime from the current version
    of Microsoft.Build.dll, as identified by the active runtime.

    The old IntrinsicFunctions test is no longer meaningful and has been removed

    This fixes Issue dotdevelop#75 so that all project properties are now evaluated correctly.
….4 or greater

or for DotNetCore (runtime) versions 3.x or greater (ie includes .net5.0+)

    previously only netstandard2.0 was supported for mono 5.2 AND netcore3.0 installed
…DotnetCore.addin.xml

and MonoDevelop.ASpNetCore.addin.xml to allow net5.0 and net6.0 projects to be created

These template updates  were overlooked in the menu limit changes in PR#76
1 - use 'git submodule deinit main/external/nuget-binary' to remove submodule from .git/config
2 - use 'git rm main/external/nuget-binary' to remove submodule from work tree
This commit updates all NuGet dll binaries to release-5.8
ready to support .net5.0 projects

Note that the main/external/nuget-binary folder (and all its contents)
are no longer a submodule in the DotDevelop repo, but just a normal folder
under the control of the main DotDevelop git repo.
NuGet.Client release-5.8.x (and later) is able to handle .net5.0 projects
To allow DotDevelop to build with this release of Nuget a number of small changes
are needed to the DotDevelop PackageManagement files because the interface to
NuGet changed after release-5.4.0 (which DotDevelop currently builds with)

The commits in this 'net5ff_nuget' branch also remove 'nuget-binary' from being
an external submodule within the DotDevelop repo, since 'nuget-binary' has not
been updated since MonoDevelop was archived. Instead, the folder with the NuGet dlls
is now a simple folder under DotDevelop's version control. This simplifies updating
NuGet to later releases, which will be required to handle .net6.0+ frameworks.

With these commits, net5.0 projects can be created, saved, etc, which effectively fixes
Issue dotdevelop#79 (project.assets.json gets a wrong TargetFrameworkMoniker for net5 and higher)
Use hwt-dev as development branch
Add first PR to dotdevelop
  Incorporate changes in PR#81 from @gluckez to fix conflicts
@hwthomas
Copy link
Collaborator Author

Try to fix intermittent CI failures by removing last nuget/api/v2 URLs in fsharpbinding repo.

@hwthomas
Copy link
Collaborator Author

hwthomas commented Nov 23, 2022

@lytico, @knuxbbs - I'd be grateful if you could review this series of PRs (#77, #87, #90, #91, #93) with a view to merging - perhaps into a new develop branch if you feel they are not yet stable enough for main.

Taken together, these changes allow net5.0/net6.0 projects to be created, built and run, and would allow some more extensive testing of DotDevelop to be started - hopefully by some new contributors as well!

@gluckez
Copy link
Collaborator

gluckez commented Dec 6, 2022

@hwthomas @lytico I think having a develop branch is a good idea, as well as using feature branches for developers working on seperate features before they go in testing. There is already a develop branch, but the policies need to be updated to set this as the main working branch. Could you do that? it is already up to date with main.

@hwthomas
Copy link
Collaborator Author

hwthomas commented Dec 6, 2022

@gluckez The develop branch was created by me (accidentally - I intended to be on my own fork!) but I'm not sure of the relative benefits (or problems) of having this as the default working branch. @lytico What are your thoughts?

@gluckez
Copy link
Collaborator

gluckez commented Dec 7, 2022

@hwthomas there are several benefits. You could set up the policies for only allowing to merge branches into develop, so we're sure that the main release branch remains untouched until everything is tested properly. You could set up a CICD pipeline for a pre-release for others to test before making a new release. You can use wildcards to use the latest nuget packages of the dependencies on develop, before fixing them on the main branch, and the pre-release or nightly pipelines would identify issues with updated api's. this way we know we're always using the latest compatible versions. but I'll leave all that to the maintainers xD

hwthomas added a commit to hwthomas/dotdevelop that referenced this pull request Dec 11, 2022
This fixes failures when evaluating project properties
See Issue dotdevelop#93
hwthomas added a commit to hwthomas/dotdevelop that referenced this pull request Dec 13, 2022
    This fixes failures when reserved property $(MSBuildVersion) cannot be found
    See Issue dotdevelop#93
hwthomas added a commit to hwthomas/dotdevelop that referenced this pull request Dec 14, 2022
…nstalled

    This fixes failures when reserved property $(MSBuildVersion) cannot be found
    See Issue dotdevelop dotdevelop#93
@hwthomas hwthomas merged commit 46daf44 into dotdevelop:main Jan 11, 2023
@hwthomas hwthomas deleted the fsharp-api-v3 branch February 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants