upgrade from 5.2 to 5.3 steps #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jurj-Bogdan <[email protected]>
arhimede
reviewed
Jan 17, 2025
|
@Jurj-Bogdan you need to edit another file to have that page added to menu |
it's this file that is used to place the links in the menu |
Signed-off-by: Jurj-Bogdan <[email protected]>
bidi47
reviewed
Jan 17, 2025
mkdocs.yml
Outdated
| @@ -22,7 +22,9 @@ nav: | |||
| - "Doctrine ORM": v5/installation/doctrine-orm.md | |||
| - "Test the Installation": v5/installation/test-the-installation.md | |||
| - "FAQ": v5/installation/faq.md | |||
| - Upgrading: v5/upgrading.md | |||
| - Upgrading: | |||
| - "Upgrading": v5/upgrading/upgrading.md | |||
There was a problem hiding this comment.
I've only changed the commented line (26), i hope you didn't mean the "main menu text" as well (line 25)
bidi47
reviewed
Jan 17, 2025
| > Note that you can set the memory limit to a value of your choosing, with a recommended minimum of 256M | ||
|
|
||
| ### Update anonymization | ||
|
|
||
| By default, Dotkernel API uses "soft delete" for it's `User` entities in order to preserve the database entries. | ||
|
|
There was a problem hiding this comment.
do we need this much spacing between these phrases? the other sections also have 3 separate paragraphs, but i think it's better to merge them as they are on a single topic
bidi47
reviewed
Jan 17, 2025
| Starting from version 5.3 the `isDeleted` property has been removed because, by default, there is no use in having both it and the status property. | ||
|
|
||
| As such, a new `Deleted` case for `UserStatusEnum` is now used to mark a deleted account and remove the redundancy. | ||
|
|
||
| * [BC Break] Remove the `isDeleted` property from the `User` class, alongside all usages, as seen in the [pull request](https://github.com/dotkernel/api/pull/359/files) | ||
| * Add a new "deleted" case to `UserStatusEnum`, which is to be used instead of the previous `isDeleted` property | ||
| * Update the database and it's migrations to reflect the new structure |
Signed-off-by: Jurj-Bogdan <[email protected]>
Signed-off-by: Jurj-Bogdan <[email protected]>
arhimede
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know of any changes. Also, should it be more in depth?
closes #84