Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #321: Replace built-in PHP server usage with WSL.#354

Merged
arhimede merged 4 commits into
4.0from
issue-321
Feb 22, 2023
Merged

Issue #321: Replace built-in PHP server usage with WSL.#354
arhimede merged 4 commits into
4.0from
issue-321

Conversation

@alexmerlin
Copy link
Copy Markdown
Member

No description provided.

@alexmerlin alexmerlin requested a review from arhimede February 21, 2023 15:56
@alexmerlin alexmerlin self-assigned this Feb 21, 2023
Copy link
Copy Markdown
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tested from a fresh wsl container to a functional frontend ?

@alexmerlin
Copy link
Copy Markdown
Member Author

It was tested from a fresh wsl container to a functional frontend ?

Yes, I just tested, but...

Note:
With the changes from this PR the developer would have to set manually the correct URL stored in the $baseUrl variable.
We could avoid this step if we use the HTT_HOST and generate the URL automatically by setting:

$baseUrl = 'http://' . $_SERVER['HTTP_HOST'];

in the local.php file.

@alexmerlin alexmerlin requested a review from arhimede February 22, 2023 08:11
Copy link
Copy Markdown
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in local.php.dist
cocatenate $_SERVER['REQUEST_SCHEME'] with HTTP_HOST

Copy link
Copy Markdown
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$baseUrl = 'http://localhost:8080';
$baseUrl = 'http://frontend.dev';

@alexmerlin alexmerlin requested a review from arhimede February 22, 2023 10:25
@arhimede arhimede merged commit 9d8ab0a into 4.0 Feb 22, 2023
@arhimede arhimede deleted the issue-321 branch February 22, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants