Conversation
alexmerlin
requested changes
Jul 19, 2023
Member
alexmerlin
left a comment
There was a problem hiding this comment.
- On this page:
/account/avatar, the UI is broken (see image at the end of my comments). After I upload an image, it is not displayed on the page. I checked on the server, the file is uploaded, it's just not displayed. - I see the following error in the console:
Uncaught TypeError: e.fileinput is not a function
thrown in app.js.
Other than the above observations, DK Frontend seems to be functional.
I'm adding @cPintiuta as a reviewer, as he contributed to the Bootstrap V5 migration in DK Admin and he might have some valuable input on some items I might have overseen on this PR.
Member
|
@mada27 Please let us know if anything unclear regarding my last review on this PR. |
Member
|
@mada27 Do you have any updates on the open items (avatar page design issue) in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.