Conversation
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
alexmerlin
requested changes
Oct 19, 2023
Member
alexmerlin
left a comment
There was a problem hiding this comment.
Please fix the following:
- remove phpcs.xml.dist, phpunit.xml.dist
- make sure phpcs.xml covers the below directories, then fix the errors, if any:
<file>bin</file> <file>config</file> <file>data/doctrine/fixtures</file> <file>public</file> <file>src</file> <file>test</file>
src/User/src/InputFilter/LoginInputFilter.phpandsrc/User/src/InputFilter/RequestResetPasswordInputFilter.phpadd return type hint to:
public function init(): void
- Once you run PHPCS on the above-mentioned directories as well, you'll find plenty more issues to fix - I did not get further into the details where it's only a question of text aligninment
- Convert line endings (where needed) from
CRLF->LFand make sure there's an empty line at the end of the files. - Reorder the badges as seen here and add Codecov badge:
[](https://codecov.io/gh/dotkernel/frontend)
This was
linked to
issues
Oct 19, 2023
Closed
alexmerlin
requested changes
Oct 26, 2023
Member
alexmerlin
left a comment
There was a problem hiding this comment.
Also, please add local.test.php to config/autoload/.gitignore.
alexmerlin
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.