Fix empty response #559
Fix empty response #559
Conversation
- Fixed Benchmark project
…into fix/EmptyResponse
Use editorconfig from roslyn team
| void ResetImports(); | ||
|
|
||
| /// <summary> | ||
| /// Gets the all already imported files |
src/dotless.AspNet/HandlerImpl.cs
Outdated
| var source = FileReader.GetFileContents(localPath); | ||
|
|
||
| // Due to the Importer is a singleton, we should always reset the already imported files (#555) | ||
| Engine.ResetImports(); |
There was a problem hiding this comment.
Hmm... I wonder if we could do better because this looks like it might cause issues - esp. with multiple threads calling this
Any way we can get rid of the singleton? Would be way better IMO..
There was a problem hiding this comment.
I'm glad Daniel is awake, since I clearly wasn't. Yes, this will be an issue with multiple threads. In fact, the entire current implementation of Importer is non-threadsafe.
@Tigraine, do you know of a reason why Parser and Importer couldn't be registered as transients in the container? Because I'm thinking that would be the best way to get around this.
There was a problem hiding this comment.
No I honestly don't know why this was done that way. I suspect it has something to do with the Importer not being able to be passed through the chain to the nodes so it's easier to use a singleton?
There was a problem hiding this comment.
I removed this all and registered the parser and importer as transient.
| return duration.Milliseconds; | ||
| }) | ||
| { | ||
| engine.ResetImports(); |
There was a problem hiding this comment.
Also this leads to these cases where you have to remember to call ResetImports()
Get benchmark project working again
…into fix/EmptyResponse
Resets the already imported files on the importer, cause this is a singleton instance.
Will fix #555