deps: Update package dependencies #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0596bb to
10e69fd
Compare
10e69fd to
c57ad52
Compare
adamsitnik
approved these changes
Jun 5, 2025
| foreach (var version in targetVersions) | ||
| { | ||
| AddJob(baseJob.WithNuGet("Newtonsoft.Json", version) | ||
| .WithCustomBuildConfiguration(version) |
There was a problem hiding this comment.
Was the WithCustomBuildConfiguration change required to get it to work? If so, why?
There was a problem hiding this comment.
I've removed WithCustomBuildConfiguration setting on latest commit.
When I've tested on v0.14.0 based code previously. wrong DLL version are placed on benchmarks bin directory.
But it seems not needed with latest code (that using ArtifactsPath for benchmark project build)
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" /> | ||
| <!-- Reference System.Numerics.Vectors 4.5.0 (that support net461) as minimum version to avoid MSB3277 warning --> |
There was a problem hiding this comment.
Thank you for adding the comment 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update package dependencies to latest versions.
How to confirms outdated packages
Run following command.
List of updated packages
FSharp.Core4.6.09.0.300Iced1.17.01.21.0JetBrains.Profiler.SelfApi2.5.112.5.13Microsoft.CodeAnalysis.CSharp4.12.04.14.0Microsoft.Diagnostics.Runtime1.1.1261023.1.512801Microsoft.Diagnostics.Tracing.TraceEvent3.1.83.1.21Microsoft.NETCore.Platforms6.0.07.0.4Microsoft.NETFramework.ReferenceAssemblies1.0.21.0.3Microsoft.NET.Test.Sdk17.7.2[17.13.0]Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers17.13.35606.118.0.36127.1Newtonsoft.Json13.0.1[13.0.1]ScottPlot5.0.545.0.55System.Configuration.ConfigurationManager4.5.09.0.5System.Drawing.Common4.7.29.0.5System.Management6.0.09.0.5System.Memory4.5.54.6.3System.Runtime.CompilerServices.Unsafe6.0.06.1.2System.Threading.Tasks.Extensions4.5.44.6.3System.ValueType4.5.04.6.1Verify.Xunit20.8.230.3.1xunit2.9.22.9.3xunit.runner.visualstudio2.4.1[2.8.2]Note
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworksproject contains legacy targets (.NET461andnetcoreapp2.0) So it need to usexunit.runner.visualstudiov2.4.1 that compatible these frameworks.Microsoft.NET.Test.Sdk14.0.0 or later depends on NewtonsoftJson13.0.3. So it can't update versionsSystem.Numerics.Vectorsfornetstandard2.0build need to reference4.5.0version (that support net461).Other changes
1.
BenchmarkDotNet.Samples.csprojIntroNativeMemory.csAdd custom benchmark filter (
WindowsOnlyAttribute) to exclude benchmarks that not works on non-Windows OS.(Because
System.Drawing.Commonis not supported .NET 6.0 or later)IntroNuGet.csModify benchmarks to use Newtonsoft.Json
13.0.1as baseline package.And add
WithCustomBuildConfigurationsettings. (It's required when targeting multiple NuGet versions)2.
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csprojNU1901/NU1902/NU1904.3. Remove
[UsesVerify]attributesThis attribute is removed on latest
xUnit.Verifypackage.Additional manual tests
IntroNuGet/IntroVisualStudioProfilerbenchmark behaviorsBenchmarkDotNet.IntegrationTests.ManualRunningtests behaviors. (Blocked by Some of the tests defined in theBenchmarkDotNet.IntegrationTests.ManualRunningproject failed to run #2751)BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworkstests behaviors.