Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jun 12, 2025

This PR intended to fix issue #2768.

What's changed in this PR

  1. Add JobOrderPolicy that similar to SummaryOrderPolicy/MethodOrderPolicy
  2. Modify DefaultOrderer/JobComparer/OrdererAttribute to accept JobOrderPolicy parameter.
  3. Add NumericStringComparer nested class to JobComparer. this class compare string with numeric ordering.
  4. Add unit tests to JobOrderTests.cs

Note: This PR don't change existing behaviors. Numeric job ordering feature is enabled when explicitly enabled.

List of Job characteristics
Job characteristics is compared by following priorities.

foreach (var characteristic in x.GetAllCharacteristics())
{
if (!x.HasValue(characteristic))
{
if (y.HasValue(characteristic))
return -1;
continue;
}
if (!y.HasValue(characteristic))
{
if (x.HasValue(characteristic))
return 1;
continue;
}
int compare = string.CompareOrdinal(
presenter.ToPresentation(x, characteristic),
presenter.ToPresentation(y, characteristic));
if (compare != 0)
return compare;
}

  [0]: {Id}
  [1]: {Accuracy}
  [2]: {AnalyzeLaunchVariance}
  [3]: {EvaluateOverhead}
  [4]: {MaxAbsoluteError}
  [5]: {MaxRelativeError}
  [6]: {MinInvokeCount}
  [7]: {MinIterationTime}
  [8]: {OutlierMode}
  [9]: {Environment}
  [10]: {Affinity}
  [11]: {EnvironmentVariables}
  [12]: {Jit}
  [13]: {LargeAddressAware}
  [14]: {Platform}
  [15]: {PowerPlanMode}
  [16]: {Runtime}
  [17]: {Gc}
  [18]: {AllowVeryLargeObjects}
  [19]: {Concurrent}
  [20]: {CpuGroups}
  [21]: {Force}
  [22]: {HeapAffinitizeMask}
  [23]: {HeapCount}
  [24]: {NoAffinitize}
  [25]: {RetainVm}
  [26]: {Server}
  [27]: {Infrastructure}
  [28]: {Arguments}
  [29]: {BuildConfiguration}
  [30]: {Clock}
  [31]: {EngineFactory}
  [32]: {NuGetReferences}
  [33]: {Toolchain}
  [34]: {Meta}
  [35]: {Baseline}
  [36]: {IsDefault}
  [37]: {IsMutator}
  [38]: {Run}
  [39]: {InvocationCount}
  [40]: {IterationCount}
  [41]: {IterationTime}
  [42]: {LaunchCount}
  [43]: {MaxIterationCount}
  [44]: {MaxWarmupIterationCount}
  [45]: {MemoryRandomization}
  [46]: {MinIterationCount}
  [47]: {MinWarmupIterationCount}
  [48]: {RunStrategy}
  [49]: {UnrollFactor}
  [50]: {WarmupCount}

@filzrev filzrev force-pushed the feat-add-options-sort-jobs-numericorder branch 2 times, most recently from 58bc8cd to a93bf0e Compare June 12, 2025 10:42
@filzrev filzrev force-pushed the feat-add-options-sort-jobs-numericorder branch from a93bf0e to fb0373b Compare June 12, 2025 11:25
Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @filzrev!

@timcassell timcassell merged commit 6730bf1 into dotnet:master Jun 13, 2025
8 checks passed
@timcassell timcassell added this to the v0.15.2 milestone Jun 13, 2025
microsoft-github-policy-service bot pushed a commit to Azure/bicep that referenced this pull request Sep 21, 2025
Updated [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet)
from 0.14.0 to 0.15.3.

<details>
<summary>Release notes</summary>

_Sourced from [BenchmarkDotNet's
releases](https://github.com/dotnet/BenchmarkDotNet/releases)._

## 0.15.3

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.3.html

## Highlights

Improvements:

- Naot instruction set support for .NET 10+, migrate to ISA groupings in
CPU summary
[#​2828](dotnet/BenchmarkDotNet#2828)
- Support benchmark filtering for TestAdapter
[#​2662](dotnet/BenchmarkDotNet#2662)
[#​2788](dotnet/BenchmarkDotNet#2788)
- Support non-primitive external types in `ArgumentsSource`
[#​2820](dotnet/BenchmarkDotNet#2820)
- Enable MSBuild parallel build via `--nodeReuse:false`
[#​2693](dotnet/BenchmarkDotNet#2693)
[#​2814](dotnet/BenchmarkDotNet#2814)
- Improve CPU detection
[#​2747](dotnet/BenchmarkDotNet#2747)
[#​2749](dotnet/BenchmarkDotNet#2749)
- Enable assembly signing for debug build
[#​2774](dotnet/BenchmarkDotNet#2774)

Deprecations:

- Deprecated `WithNuget`
[#​2812](dotnet/BenchmarkDotNet#2812)

Bug fixes:

- Fix `InvalidOperationException` in diagnosers
[#​2758](dotnet/BenchmarkDotNet#2758)
[#​2805](dotnet/BenchmarkDotNet#2805)
- Fix file detection in `NativeMemoryProfiler`
[#​2794](dotnet/BenchmarkDotNet#2794)
[#​2795](dotnet/BenchmarkDotNet#2795)
- Fix long file paths issue in `EtwProfiler`
[#​2807](dotnet/BenchmarkDotNet#2807)
[#​2808](dotnet/BenchmarkDotNet#2808)
- Fix log duplications in TestAdapter
[#​2790](dotnet/BenchmarkDotNet#2790)
- Fix x86 disassembler error for net462
[#​2792](dotnet/BenchmarkDotNet#2792)
- Fix `IsNetCore` and `IsNativeAOT` for single-file apps without AOT
[#​2799](dotnet/BenchmarkDotNet#2799)
- Fix density plot generation in `RPlotExporter` for latest version of R
[#​2809](dotnet/BenchmarkDotNet#2809)


## 0.15.2

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.2.html

## Highlights

- The most significant update in this release is the enhanced accuracy
of the memory diagnoser
([#​2562](dotnet/BenchmarkDotNet#2562)). This
improvement resolves the issue of incorrectly reported memory
allocations
([#​1542](dotnet/BenchmarkDotNet#1542),
[#​2582](dotnet/BenchmarkDotNet#2582)).
- We have introduced a new feature that allows users to sort benchmark
jobs in numerical order
([#​2768](dotnet/BenchmarkDotNet#2768),
[#​2770](dotnet/BenchmarkDotNet#2770)).
- Benchmark validation has been improved
([#​2771](dotnet/BenchmarkDotNet#2771)).
- An issue with non-persistent auto-generated JobId has been fixed
([#​2777](dotnet/BenchmarkDotNet#2777)).


## 0.15.1

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.1.html

## Highlights

- Added support for *.slnx
([#​2763](dotnet/BenchmarkDotNet#2763),
[#​2764](dotnet/BenchmarkDotNet#2764))
- Enabled ArgumentsSource to reference methods in other types
([#​2744](dotnet/BenchmarkDotNet#2744),
[#​2748](dotnet/BenchmarkDotNet#2748))
- Resolved fatal errors for ARM CPUs
([#​2745](dotnet/BenchmarkDotNet#2745),
[#​2756](dotnet/BenchmarkDotNet#2756))
- Fixed bugs related to support for Android, browser, iOS, and tvOS
([#​2739](dotnet/BenchmarkDotNet#2739),
[#​2741](dotnet/BenchmarkDotNet#2741),
[#​2740](dotnet/BenchmarkDotNet#2740),
[#​2742](dotnet/BenchmarkDotNet#2742))



## 0.15.0

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.0.html



Commits viewable in [compare
view](dotnet/BenchmarkDotNet@v0.14.0...v0.15.3).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=BenchmarkDotNet&package-manager=nuget&previous-version=0.14.0&new-version=0.15.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/18084)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add custom option to sort benchmark jobs by numeric orders
2 participants