Exclude template specializations unless generate-template-bindings is set
#551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return (_config.ExcludeFunctionsWithBody && (cursor is FunctionDecl functionDecl) && functionDecl.HasBody) | ||
| || (!_config.GenerateTemplateBindings && (cursor is TemplateDecl)); | ||
| || (!_config.GenerateTemplateBindings && ((cursor is TemplateDecl) || (cursor is ClassTemplateSpecializationDecl))); |
There was a problem hiding this comment.
Some other template related declarations that don't inherit from these two include:
FriendTemplateDeclNonTypeTemplateParmDeclTemplateParamObjectDeclTemplateTypeParmDeclVarTemplatePartialSpecializationDeclVarTemplateSpecializationDecl
Of these, I think VarTemplateSpecializationDecl and VarTemplatePartialSpecializationDecl are the only two that don't require first being in an already skipped templated declaration context. But it may be important to look a bit more deeply.
tannergooding
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClangSharp currently excludes templates unless the
generate-template-bindingsconfig option is set, but it still visits template specialization declarations, resulting in the warningClass template specializations are not supported.This change excludes template specializations unless the
generate-template-bindingsconfig option is set.