#2298 override ToString() method for vulkan objects #2323
Conversation
There was a problem hiding this comment.
Hey, thanks so much for contributing to Silk.NET! And more notably, for trying to get stuck in to BuildTools - it's a rather complicated beast, and I always welcome anyone wanting to brave a change in there.
I actually swept this up around the same time as you submitted this PR in #2184, and I think I'll have that supersede this PR if that's okay with you? :) Feel free to see what I implemented over there re the comment below
| @@ -503,6 +503,16 @@ public static void WriteStruct | |||
| sw.WriteLine(); | |||
| } | |||
|
|
|||
| var handleField = @struct.Fields.FirstOrDefault(t => t.Name == "Handle" && t.Type.Name == "ulong"); | |||
There was a problem hiding this comment.
Good spot, but this isn't quite the right place to put it as this will generate for every structure (including those that don't have a Handle field). What I decided to do in my PR is handle this in the VulkanReader i.e. right at the source of the generation of those Handle fields. But something at this layer would've worked too with a check for a structure being handle-like! Many ways to skin a cat :)
Summary of the PR
Adds an override of the ToString() method to structures to output the Handle field
Related issues, Discord discussions, or proposals
Issue 2298
Further Comments