Merged
Conversation
Member
Author
|
HurricanKai
requested changes
Nov 29, 2020
Member
HurricanKai
left a comment
There was a problem hiding this comment.
Imo Core should generate as little stuff specific to one thing as possible, and no generated code at all. Not sure why all these D3D types are in Core now.
Also , I can't be bothered to review the 1400 generated files.
Comment on lines
+8
to
+29
| public struct TagRect | ||
| { | ||
| public long Left, Top, Right, Bottom; | ||
| } | ||
|
|
||
| public struct TagPoint | ||
| { | ||
| public long X, Y; | ||
| } | ||
|
|
||
| public struct TagSize | ||
| { | ||
| public long Width, Height; | ||
| } | ||
|
|
||
| public struct TagPaletteEntry | ||
| { | ||
| public byte PeRed; | ||
| public byte PeGreen; | ||
| public byte PeBlue; | ||
| public byte PeFlags; | ||
| } |
Member
There was a problem hiding this comment.
Remember to replace with Rectangle<long>, Vector2<long>, Vector2<long> and Vector4<byte>
Co-authored-by: Kai Jellinghaus <[email protected]>
HurricanKai
approved these changes
Nov 29, 2020
Perksey
added a commit
that referenced
this pull request
Mar 25, 2022
* Add args and be more tolerant of failures * Initial bindings with no COM, initial COM support in BuildTools * Complete Direct3D 11 and DXGI bindings * Start D3D12 work, move D3DCommon into Silk.NET.Core * Add d3d11shader.h, BuildTools bug fixes * Finish D3D12 bindings, add ComPtr & ComObject * Direct3D 9 Bindings * DXC and D3DCompiler bindings * Push (disabled) config for Direct2D * NUKE fixes * Continued * Binder improvements * More COM-related improvements * Revert SDL generator overwrite * Add XInput and XAudio * Finishing touches * Update src/Microsoft/Silk.NET.DXGI/DXGILibraryNameContainer.cs Co-authored-by: Kai Jellinghaus <[email protected]> * GUIDs * Remove ZeroStart now it's no longer used Co-authored-by: Kai Jellinghaus <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds bindings to various DirectX/Windows APIs.
Related issues, Discord discussions, or proposals
#48
Further Comments
Because the JVM was being a big meanie.