Initial XML generation from C++ #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good thing we squash PRs... For some reason my local git install prepends the current path if the commit message starts with |
Perksey
approved these changes
May 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This only gets XML from a C++ header file. The configuration options are minimal, to allow incrementally adding the things we actually need.
Related issues, Discord discussions, or proposals
Links go here.
Further Comments
Note that the branch is inappropriately named, I've decided to develop the second part of this feature, visiting the XML and scraping the symbols from it, in a separate PR.
There are a lot of deletions of code in this PR. This is only to ensure having fully tested code, and I'll work to restore all of the code in one way or another down the road.
Docs aren't updated & out of date, I can fix this but I think due to the amount of changes that are currently happening there is no sense in writing docs while I still rework the code.