Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Eng | Add strong name validation to package validator #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Eng | Add strong name validation to package validator #2802

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ce38ab
add strong name validator to package validator
Aug 21, 2024
d774e71
add official pipeline check
Aug 21, 2024
e037ade
Apply suggestions from code review
Aug 21, 2024
d793bf0
fix type/oversight
Aug 21, 2024
7da2e6d
Merge branch 'add-sn.k-to-package-validator' of https://github.com/jr…
Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion eng/pipelines/common/templates/jobs/validate-signed-package-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,42 @@ jobs:
}
displayName: 'Verify nuget signature'

- powershell: |
if($env:CDP_BUILD_TYPE -eq 'Official')
{
# Recursively find all .dll files in TempFolder (installed nuget folder)
# Microsoft.Data.SqlClient.dll and Microsoft.Data.SqlClient.resources.dll (in localized folders) should have strong name
$dllFiles = Get-ChildItem -Path $(TempFolderName) -Recurse -Filter *.dll
$badDlls = @()
foreach ($file in $dllFiles)
{
# Run sn.k to verify the strong name on each dll
$result = & "C:\Program Files (x86)\Microsoft SDKs\Windows\*\bin\NETFX 4.8.1 Tools\sn.exe" -vf $file.FullName
Write-OutPut $result

# if thhe dll is not valid, it would be delay signed or test-signed which is not meant for production
if($result[$result.Length-1] -notlike "* is valid")
{
$badDlls += $result[$result.Length-1]
}
}
if($badDlls.Count -gt 0)
{
Write-OutPut "Error: Invalid dlls are detected. Chek below list:"
foreach($dll in $badDlls)
{
Write-Output $dll
}
Exit -1
}
Write-Host "Strong name has been verified for all dlls"
}
else
{
Write-OutPut "Strong name verification is not required for non-official builds"
}
displayName: 'Verify strong name is generated for production'

- powershell: |
# Checks the expected folder names such as lib, ref, runtimes
Get-ChildItem -Path $(extractedNugetPath) -Directory | select Name | foreach {
Expand Down Expand Up @@ -208,7 +244,6 @@ jobs:
}
}
displayName: 'Verify all DLLs unzipped match "expected" hierarchy'

- powershell: |
# Verify all dlls status are Valid

Expand Down
Loading