[Mono.Android] fix "replaceable" objects in ManagedValueManager
#10107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test is failing on NativeAOT as well as any case we'd use
ManagedValueManager
:With the assertion:
The second assertion fails because
registered
is the same instance asintermediate
. In this example, this is a code path whereintermediate
should be "replaced" withadapter
.After lots of debugging, I found the problem are these lines in the
ManagedValueManager.AddPeer()
method:If we
PeekPeer()
in the middle ofAddPeer()
and a type is "replaceable", it would find an instance and not replace it! I did not find equivalent code inAndroidValueManager.AddPeer()
, which is what is used in Mono & production today.This was also addressed in Java.Interop's
ManagedValueManager
here:This also solves a test failure in
Java.Interop-Tests
: