Fix detection of nested types #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g nested ones like delegates, using the AllTypesVisitor. Simplify code considerably.
…the loaded test csproj.
|
Need to fix this in the yml. I'll send it in a separate PR: |
|
Closing/reopening to auto rebase. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing the MSBuild problem, the unit tests uncovered a problem when attempting to detect nested types, specifically, delegates. Turns out the way symbols were being visited before was not a proper way of ensuring nested types would also be visited. Instead, I added a CSharpVisitor instance and now all the symbols get pre-collected, and then paired up with the docs types afterwards.
The tests now pass.