fix ArgumentNullException when accessing SymbolLocations #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
As discussed in chat, this is the least invasive way to fix this. I would've preferred a lazy initialization to get all the places that use the enumerable fixed at once.
A local test succeeded for the real case scenario (System.IO.Compression.ZipFile).
The CI failure prevented running the tests, but the issue is unrelated to this.
|
If the unit tests pass locally, feel free to merge. Can you please open an issue for the nuget failure in the CI? |
2288fa8 to
f136731
Compare
…cs-sync into null-exception
carlossanlop
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.