Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix ArgumentNullException when accessing SymbolLocations #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023
Merged

fix ArgumentNullException when accessing SymbolLocations #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41c5e12
fix ArgumentNullException when accessing SymbolLocations
smasher164 Jan 11, 2023
8bb9103
update nuget packages
carlossanlop Jan 11, 2023
2288fa8
Update tests nuget package from arcade
carlossanlop Jan 11, 2023
f136731
add nuget.config
smasher164 Jan 11, 2023
510e96e
Merge branch 'null-exception' of https://github.com/smasher164/api-do…
carlossanlop Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions nuget.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<clear />
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
<add key="arcade" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
</packageSources>
</configuration>
3 changes: 3 additions & 0 deletions src/PortToTripleSlash/src/libraries/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Collections.Generic;
using System.Linq;

namespace ApiDocsSync.PortToTripleSlash
{
Expand Down Expand Up @@ -59,6 +60,8 @@ public static string DocIdEscaped(this string docId) =>
// Checks if the passed string is considered "empty" according to the Docs repo rules.
public static bool IsDocsEmpty(this string? s) =>
string.IsNullOrWhiteSpace(s) || s == Configuration.ToBeAdded;

public static bool HasItems<T>(this IEnumerable<T> src) => src?.Any() ?? false;
}

}
2 changes: 1 addition & 1 deletion src/PortToTripleSlash/src/libraries/ToTripleSlashPorter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private async Task CollectSymbolLocationsFromReferencedProjectsAsync(DocsType do
}
}

if (!docsType.SymbolLocations.Any())
if (!docsType.SymbolLocations.HasItems())
{
Log.Error($"No symbols found for docs type '{docsType.DocId}'.");
}
Expand Down
18 changes: 9 additions & 9 deletions src/PortToTripleSlash/src/libraries/libraries.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Build" Version="17.2.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Framework" Version="17.2.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Locator" Version="1.4.1" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.3.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4-beta1.22310.1">
<PackageReference Include="Microsoft.Build" Version="17.4.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Framework" Version="17.4.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Locator" Version="1.5.5" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.5.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4-beta1.22559.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.3.0-2.final" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="7.0.0-preview.6.22324.4" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.5.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.5.0-2.final" />
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.5.0-2.final" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="7.0.0" />
</ItemGroup>

</Project>
10 changes: 5 additions & 5 deletions src/PortToTripleSlash/tests/tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Build" Version="17.2.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Framework" Version="17.2.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.DotNet.XUnitExtensions" Version="8.0.0-beta.22579.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0-preview-20220707-01" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="7.0.0-preview.6.22324.4" />
<PackageReference Include="Microsoft.Build" Version="17.4.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Framework" Version="17.4.0" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.DotNet.XUnitExtensions" Version="8.0.0-beta.23060.7" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0-preview-20221221-03" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="7.0.0" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PrivateAssets>all</PrivateAssets>
Expand Down