Merge carlossanlop/main with jeffhandley/retain-directives #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db1270b to
c285525
Compare
c285525 to
99c376a
Compare
carlossanlop
commented
Sep 10, 2021
Comment on lines
+15
to
+16
| public override string ReturnType { get; } | ||
| public override string Returns { get; set; } |
There was a problem hiding this comment.
This was the only manual change I had to add so the project could build: The DocsAPI abstract class now implements ReturnType and Returns. This is because delegates are Types, and they can have a return value, just like a Member method.
|
Next step: Figure out why the Roslyn VSInstance code is not working... again. I updated the dependencies, but I'm still having trouble getting it to work. |
14 tasks
* Use Verify tests to visually assert correctness * Remove redundant "source" files
4969711 to
4bb7079
Compare
|
@carlossanlop @jeffhandley I've been trying to fix tests but it's painfully slow and at times I get completely lost... Am I moving in the right direction? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeffhandley I pulled all the changes in
maininto a copy of your branch, and this is the result.If you're ok with that, let's work on this branch from now on. I will leave some comments summarizing what's new.