Reduce likelyhood that large containers cause OOMs when repacking #13800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'Using' archive stream in ZipData.cs - When repacking, make an initial pass over the container set to separate out large/small containers. Then repack small ones in parallel, and large ones in serial. Large and small are determined by a 2GB limit/max parallelism. In the code, we could have used two loops instead of 3. Instead, I prioritized printing the correct number of containers being packed in parallel vs. serial.
|
Waiting on an additional test that just has the fix with the stream disposal. |
epananth
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code, we could have used two loops instead of 3. Instead, I prioritized printing the correct number of containers being packed in parallel vs. serial.
To double check: