Fix restore internal tools condition #14979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ManifestTool is only needed when GenerateSbom is true. This fixes the condition to only restore internal tools when needed.
|
It should also fix issue in dotnet/test-templates#426 |
|
It's building locally with the change but I am not sure this is perfectly matching the CI scenario. If there is some kind of |
Evangelink
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ManifestTool is only needed when GenerateSbom
is true. This fixes the condition to only restore
internal tools when needed.
Fixes issues in dotnet/fsharp#17429
To double check: