[release/8.0] Fix SBoM generation #15603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
approved these changes
Mar 7, 2025
| @@ -38,6 +38,7 @@ parameters: | |||
| enableSbom: true | |||
| PackageVersion: 7.0.0 | |||
| BuildDropPath: '$(Build.SourcesDirectory)/artifacts' | |||
| ManifestDirPath: $(Build.ArtifactStagingDirectory)/sbom | |||
There was a problem hiding this comment.
nit: nothing is really using this
There was a problem hiding this comment.
The original change was passign it down to the sbom step. This is not needed for correctness and it's fine to leave out of servicing changes
mmitche
approved these changes
Mar 7, 2025
akoeplinger
added a commit
that referenced
this pull request
Mar 14, 2025
#15603 accidentally removed parts of the line, causing errors when running the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #15578 but for the release/8.0 branch.
1ES templates generates SBoM's for all artifacts uploaded - only issue is it does it in the root of the artifact that's uploaded inside the _manifest folder. If there's a manifest in the uploaded artifact, it will clobber the SBOM with an SBOM for the SBOM. The quick and dirty solution for now: generate the SBoM in a subdirectory of the upload root.