Allow source-build cache setup if SetUpSourceBuildIntermediateNupkgCache is true
#15854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks dotnet/source-build-reference-packages#1253 and resolves a regression introduced by #15810.
The regression stems from changes that require passing
/p:DotNetBuildRepo=trueor/p:ArcadeBuildFromSource=truein order to set up the source-build intermediate cache. Due to the logic inDotNetBuild.props, passing these properties when building dependency package projects causes infinite recursing.To break the recursion and issues caused by the lack of SB intermediate cache, the import of
SourceBuildArcadeTools.targetsmust be conditioned not only onDotNetBuildRepoorArcadeBuildFromSource, but also onSetUpSourceBuildIntermediateNupkgCache.