[release/9.4] Add GitHub Models integration (#10170) (#10313) #10316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Backports typo fixes for the GitHub Models integration documentation and code.
- Corrects phrasing in the README user secrets section
- Fixes a spelling mistake in the health check error message
- Normalizes the “GitHub Models” casing in the extension helper
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.GitHub.Models/README.md | Updated “The in user secrets:” to “Then in user secrets:” |
| src/Aspire.Hosting.GitHub.Models/GitHubModelsHealthCheck.cs | Corrected “resonse” to “response” in the error message |
| src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs | Changed “Github Models” to “GitHub Models” in source property |
Oh, I didn't know, or had forgotten that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport typos from the release branch PR #10313