[release/9.4] Support uninstrumented peer visualization for parameters, and resources with connection strings and github models #10382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n strings, and GitHub models Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
… string parsing Co-authored-by: davidfowl <[email protected]>
…roved documentation Co-authored-by: davidfowl <[email protected]>
…eUrlHostAndPort Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…implifying hostname validation Co-authored-by: davidfowl <[email protected]>
…solution and state management
Co-authored-by: davidfowl <[email protected]>
…ction Co-authored-by: JamesNK <[email protected]>
…omputation on each peer resolution Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
|
This broke the code mirror, see #10383 |
Looking into this. |
davidfowl
approved these changes
Jul 14, 2025
danmoseley
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10340 to release/9.4
/cc @davidfowl @copilot
Customer Impact
This PR enables uninstrumented peer visualization for parameters and resources with connection strings and GitHub models in Aspire. Customers will now be able to visualize connections and resource dependencies more accurately, even when instrumentation is not present. This improves the observability and troubleshooting experience for complex applications relying on external resources.
Testing
The changes were validated through unit and integration tests covering the new visualization logic and resource handling. Manual verification was performed to ensure that resources with connection strings and GitHub models appear correctly in the visualization, both in instrumented and uninstrumented scenarios. Automated CI pipelines for the Aspire repo also passed successfully.
Risk
Risk is moderate. While the changes largely extend existing visualization logic, they touch core components responsible for resource detection and graph rendering. There is some risk of unintended side effects in visualizations for edge cases or previously unsupported resource types. However, the changes are isolated to visualization and do not impact resource creation or connection logic.
Regression?
This change is not expected to introduce regressions in existing scenarios. The visualization updates are additive and should not affect instrumented resources or existing connection logic. However, additional testing should be done if any custom visualizations or non-standard resource providers are in use.