[release/9.4] External Services with URL Parameter fails to generate manifests #10806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to check for publish mode before calling GetValueAsync on the URL parameter Fix #10789
1 task
joperezr
approved these changes
Aug 13, 2025
|
@mitchdenny or @davidfowl this needs one more signoff |
davidfowl
approved these changes
Aug 13, 2025
This was referenced Sep 3, 2025
This was referenced Sep 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10790 to release/9.4
/cc @eerhardt
Customer Impact
When devs use the new External Service with a Url Parameter, the manifest generation can fail when passing that External Service via an Environment variable. This means
azd initwill just fail for an app with a confusing error message.Testing
Manually tested this fixes the issue. Also added a new automated test. (Note in main these tests can use Verify, but I needed to not use Verify in 9.4 since this test project doesn't use Verify yet and it is a lot of changes to use it.)
Risk
Low. The change is isolated to a new API, so it shouldn't affect any existing scenarios.
Regression?
No