-
Notifications
You must be signed in to change notification settings - Fork 695
[release/9.4] Fixed properties override when publishing an update in external service #10824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think I've seen this through Tactics yet. @davidfowl Pr looks failry simple but any notion wrt risk here? |
Filled in the info. |
Customer reported, and fixing an issue with a recent new feature. Low Risk. This meets the bar for 9.4.2, marking as approved. |
joperezr
approved these changes
Aug 28, 2025
This was referenced Sep 3, 2025
This was referenced Sep 26, 2025
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10822 to release/9.4
/cc @davidfowl @MermaidIsla
Customer Impact
Using WithParentRelationship or any method that mutates the properties on the resource is overwritten. This causes it to break expected behavior.
Testing
Manual.
Risk
Low. Only affects this new resource and is an isolated fix.
Regression?
No.