[release/9.4] Port Fix creating projects with GB18030 chars #11032
+7
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports a fix for creating projects with GB18030 characters by enabling support for non-ASCII project names on all platforms, including Windows. The key changes include adding UTF-8 byte order marks to solution file templates and updating the test project name to include more Chinese characters.
- Removes Windows-specific exclusion for Unicode project name testing
- Adds UTF-8 BOM to solution file templates to support Unicode project names
- Updates .NET SDK version for testing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Templates.Tests/TemplateTestsBase.cs | Removes Windows exclusion and adds more Chinese characters to test project name |
| src/Aspire.ProjectTemplates/templates/aspire-starter/9.4/Aspire-StarterApplication.1.sln | Adds UTF-8 BOM to solution template |
| src/Aspire.ProjectTemplates/templates/aspire-starter/9.3/Aspire-StarterApplication.1.sln | Adds UTF-8 BOM to solution template |
| src/Aspire.ProjectTemplates/templates/aspire-empty/9.4/AspireApplication.1.sln | Adds UTF-8 BOM to solution template |
| src/Aspire.ProjectTemplates/templates/aspire-empty/9.3/AspireApplication.1.sln | Adds UTF-8 BOM to solution template |
| eng/Versions.props | Updates .NET SDK version and corrects version comment |
joperezr
approved these changes
Aug 20, 2025
eerhardt
approved these changes
Aug 20, 2025
This was referenced Sep 3, 2025
This was referenced Sep 15, 2025
whytem
pushed a commit
to whytem/aspire
that referenced
this pull request
Sep 16, 2025
This was referenced Sep 17, 2025
Bump Microsoft.Extensions.ServiceDiscovery from 9.4.0 to 9.4.2
MartinWheelerDotNet/MyWhiskyShelf#107
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #11015