Add destination to span details #11424
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11424Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11424" |
There was a problem hiding this comment.
Pull Request Overview
This PR adds destination information to span details in the Aspire Dashboard, providing a link to the span's destination resource when available. The destination is determined from either an uninstrumented peer or a single child span with a different resource that acts as a server/consumer.
Key Changes
- Added
GetDestination()method toOtlpSpanto calculate span destinations - Split span properties into known properties and attribute properties for better organization
- Enhanced span details UI to display destination as a clickable resource link
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Otlp/Model/OtlpSpan.cs | Added GetDestination() method and split AllProperties() into GetKnownProperties() and GetAttributeProperties() |
| src/Aspire.Dashboard/Model/SpanDetailsViewModel.cs | Updated to use new property methods and add destination to span details |
| src/Aspire.Dashboard/Model/Otlp/SpanWaterfallViewModel.cs | Updated TraceDetailState record and method signatures to include AllResources parameter |
| src/Aspire.Dashboard/Model/Otlp/KnownTraceFields.cs | Added DestinationField constant |
| src/Aspire.Dashboard/Extensions/CollectionExtensions.cs | Added SingleOrNull extension method |
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.cs | Updated to pass resources to TraceDetailState |
| src/Aspire.Dashboard/Components/Controls/SpanDetails.razor.cs | Added destination display logic with ResourceNameButtonValue component |
| tests/Aspire.Dashboard.Tests/TelemetryRepositoryTests/OtlpSpanTests.cs | Added comprehensive tests for GetDestination() method and updated existing tests |
| tests/Aspire.Dashboard.Tests/Model/SpanWaterfallViewModelTests.cs | Updated test calls to include new AllResources parameter in TraceDetailState |
| } | ||
| else | ||
| { | ||
| if (GetChildSpans().SingleOrNull() is { } childSpan) |
There was a problem hiding this comment.
It's for when a client calling a server, and the server is configured with OTEL.
For example, frontend calls basketservice and they are both .NET projects with telemetry enabled. The client span has one server span child and so a destination is added:
Description
Span details now includes a link to the span's destination.
Fixes #10695
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate